[PATCH] D70564: [GlobalISel] LegalizationArtifactCombiner: Fix a bug in tryCombineMerges

Aditya Nandakumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 22 14:44:20 PST 2019


aditya_nandakumar added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/GlobalISel/LegalizationArtifactCombiner.h:277
+    if (llvm::canReplaceReg(DstReg, SrcReg, MRI))
+      MRI.replaceRegWith(DstReg, SrcReg);
+    else
----------------
We should probably be notifying the observer here...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70564/new/

https://reviews.llvm.org/D70564





More information about the llvm-commits mailing list