[PATCH] D70564: [GlobalISel] LegalizationArtifactCombiner: Fix a bug in tryCombineMerges

Volkan Keles via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 22 14:35:08 PST 2019


volkan updated this revision to Diff 230726.
volkan edited the summary of this revision.
volkan added a comment.
Herald added a subscriber: hiraditya.

- Added a function called `canReplaceReg` to share the code.
- Added a function called `replaceRegOrBuildCopy` that tries to replace the registers if the constraints match, and builds a COPY otherwise.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70564/new/

https://reviews.llvm.org/D70564

Files:
  llvm/include/llvm/CodeGen/GlobalISel/LegalizationArtifactCombiner.h
  llvm/include/llvm/CodeGen/GlobalISel/Utils.h
  llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp
  llvm/lib/CodeGen/GlobalISel/Utils.cpp
  llvm/test/CodeGen/AArch64/GlobalISel/artifact-combine-merge-with-constraints.mir
  llvm/test/CodeGen/Mips/GlobalISel/regbankselect/long_ambiguous_chain_s32.mir
  llvm/test/CodeGen/Mips/GlobalISel/regbankselect/long_ambiguous_chain_s64.mir
  llvm/test/CodeGen/Mips/GlobalISel/regbankselect/phi.mir
  llvm/test/CodeGen/Mips/GlobalISel/regbankselect/select.mir
  llvm/test/CodeGen/Mips/GlobalISel/regbankselect/store.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D70564.230726.patch
Type: text/x-patch
Size: 11814 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191122/aa65b79f/attachment.bin>


More information about the llvm-commits mailing list