[PATCH] D70616: [GlobalISel] CombinerHelper: Fix a bug in matchCombineCopy

[Aditya Nandakumar via Phabricator via llvm-commits]

aditya_nandakumar accepted this revision.
aditya_nandakumar added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp:87
+  if (!DstTy.isValid() || !SrcTy.isValid() || DstTy != SrcTy)
+    return false;
+
----------------
volkan wrote:
> aditya_nandakumar wrote:
> > Do we want this method to also handle the case of Regclass to Regclass copies (without any LLTs)? If yes, looks like this early exits.
> I added support for it as it's currently possible to create a register without an LLT attached, but I'm not sure if it's something we want to support in GlobalISel. What do you all think?
Thanks. This looks good to me.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70616/new/

https://reviews.llvm.org/D70616