[PATCH] D70616: [GlobalISel] CombinerHelper: Fix a bug in matchCombineCopy

[Volkan Keles via Phabricator via llvm-commits]

volkan marked 2 inline comments as done.
volkan added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp:87
+  if (!DstTy.isValid() || !SrcTy.isValid() || DstTy != SrcTy)
+    return false;
+
----------------
aditya_nandakumar wrote:
> Do we want this method to also handle the case of Regclass to Regclass copies (without any LLTs)? If yes, looks like this early exits.
I added support for it as it's currently possible to create a register without an LLT attached, but I'm not sure if it's something we want to support in GlobalISel. What do you all think?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70616/new/

https://reviews.llvm.org/D70616