[PATCH] D70536: [ARM][ConstantIslands] Correct block size update

Sam Parker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 21 05:59:22 PST 2019


samparker marked an inline comment as done.
samparker added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMConstantIslandPass.cpp:1987
       // branch. The CBN?Z is now used to branch to the other successor, so an
       // unconditional branch terminator is now redundant.
       MachineInstr *LastMI = &MBB->back();
----------------
dmgreen wrote:
> We can drop the LastMI != Br.MI? And does this comment need an update?
The comment is still valid but maybe we can remove the check... I'll see if this muddled web of logic survives that change.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70536/new/

https://reviews.llvm.org/D70536





More information about the llvm-commits mailing list