[PATCH] D70536: [ARM][ConstantIslands] Correct block size update

[Dave Green via Phabricator via llvm-commits]

dmgreen added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMConstantIslandPass.cpp:1987
       // branch. The CBN?Z is now used to branch to the other successor, so an
       // unconditional branch terminator is now redundant.
       MachineInstr *LastMI = &MBB->back();
----------------
We can drop the LastMI != Br.MI? And does this comment need an update?


================
Comment at: llvm/test/CodeGen/Thumb2/LowOverheadLoops/out-of-range-cbz.mir:130
+  !3 = !{i32 1, !"armlib_unavailable", i32 0}
+  !4 = !{!"Component: ARM Compiler 6.99 devbuild Tool: armclang [6aa8b000]"}
+  !5 = !{!6, !6, i64 0}
----------------
You can clean this up.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70536/new/

https://reviews.llvm.org/D70536