[PATCH] D70233: [WIP][Attributor] AAReachability Attribute

[pankaj gode via Phabricator via llvm-commits]

pgode marked an inline comment as done.
pgode added inline comments.


================
Comment at: llvm/include/llvm/Transforms/IPO/Attributor.h:1690
+
+  /// Returns true if 'From' instruction is assumed to reach, 'To' instruction.
+  /// Users should provide two positions they are interested in, and the class
----------------
sstefan1 wrote:
> I kind of agree with @uenoku here. If you still want to stick with `IRPosition`, then you might want to change these comments.
I looked at isKnownDead(Instruction*) and isAssumedDead(Instruction *) and I think we are expecting something similar. 
I will make the changes and submit the updated patch. 
Thanks for clarifying. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70233/new/

https://reviews.llvm.org/D70233