[PATCH] D70233: [WIP][Attributor] AAReachability Attribute

Stefan Stipanovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 20 11:37:45 PST 2019


sstefan1 added inline comments.


================
Comment at: llvm/include/llvm/Transforms/IPO/Attributor.h:1690
+
+  /// Returns true if 'From' instruction is assumed to reach, 'To' instruction.
+  /// Users should provide two positions they are interested in, and the class
----------------
I kind of agree with @uenoku here. If you still want to stick with `IRPosition`, then you might want to change these comments.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70233/new/

https://reviews.llvm.org/D70233





More information about the llvm-commits mailing list