[PATCH] D70490: [mips] Add a 'generic' Mips CPU
Simon Atanasyan via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Nov 20 13:58:35 PST 2019
atanasyan added a comment.
> removes a warning when creating a subtarget without the CPU being explicitly specified
Without this patch `llc -mtriple=mips -filetype=obj < cpus.ll` shows no error for me. How reproduce the initial problem?
================
Comment at: llvm/lib/Target/Mips/Mips.td:235
+def : Proc<"generic", []>;
def : Proc<"mips1", [FeatureMips1]>;
----------------
I think we need to explicitly specify a feature set enabled by default. In our case it's `FeatureMips32`. Otherwise it looks like the "generic" CPU has no features.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70490/new/
https://reviews.llvm.org/D70490
More information about the llvm-commits
mailing list