[PATCH] D70233: [WIP][Attributor] AAReachability Attribute

pankaj gode via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 20 09:19:54 PST 2019


pgode added a comment.

In D70233#1753619 <https://reviews.llvm.org/D70233#1753619>, @uenoku wrote:

> It seems a bit weird for me to use `IRPosition` as a program point. Therefore, I think it is better to use `Instruction` instead of `IRPosition`. So the interface will be
>
>   bool isAssumedReachable(const Instruction &From, const Instruction &To)
>
>
> What do you think?


Thanks for reviewing. I think the IRPosition gives better information than Instruction, in the reachability context.  I observe that IRPosition is created for Function, Argument, Callsite etc. 
Nevertheless, if client tries to use Instruction instead of IRPosition then we need to overload.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70233/new/

https://reviews.llvm.org/D70233





More information about the llvm-commits mailing list