[PATCH] D70233: [WIP][Attributor] AAReachability Attribute

Hideto Ueno via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 20 08:07:21 PST 2019


uenoku added a comment.

It seems a bit weird for me to use `IRPosition` as a program point. Therefore, I think it is better to use `Instruction` instead of `IRPosition`. So the interface will be

  bool isAssumedReachable(const Instruction &From, const Instruction &To)

What do you think?



================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:2066
+  void initialize(Attributor &A) override {
+    getState().indicatePessimisticFixpoint();
+  }
----------------
nit: You can call `indicatePessimisticFixpoint` directly.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70233/new/

https://reviews.llvm.org/D70233





More information about the llvm-commits mailing list