[PATCH] D70399: [llvm-readobj/llvm-readelf] - Improve dumping of versioning sections.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 19 18:05:15 PST 2019


ruiu added a comment.

In D70399#1752600 <https://reviews.llvm.org/D70399#1752600>, @MaskRay wrote:

> I agree that making the field an enumeration is an improvement, but I also feel that the closing bracket `]` on a different line is a bit verbose.
>
> Ideally we can make it on one line, e.g. `Flags []`, `Flags [ Info (0x4), 0x8]` (0x8 is an unspecified bit field. Bikeshedding on the representation welcomed!)


I agree with you that the new output looks a bit too verbose but I'd keep it consistent with other flags, as the output is in many cases consumed by programs than humans.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70399/new/

https://reviews.llvm.org/D70399





More information about the llvm-commits mailing list