[PATCH] D70399: [llvm-readobj/llvm-readelf] - Improve dumping of versioning sections.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 19 15:10:01 PST 2019


MaskRay accepted this revision.
MaskRay added a comment.

I agree that making the field an enumeration is an improvement, but I also feel that the closing bracket `]` on a different line is a bit verbose.

Ideally we can make it on one line, e.g. `Flags []`, `Flags [ Info (0x4), 0x8]` (0x8 is an unspecified bit field. Bikeshedding on the representation welcomed!)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70399/new/

https://reviews.llvm.org/D70399





More information about the llvm-commits mailing list