[PATCH] D70456: [Matrix] Add first set of matrix intrinsics and initial lowering pass.

[Florian Hahn via Phabricator via llvm-commits]

fhahn marked 2 inline comments as done.
fhahn added inline comments.


================
Comment at: llvm/docs/LangRef.rst:14417
+embedded in a flat vector and the intrinsics take the dimensions as arguments.
+Currently column-major layout is assumed. The intrinsics support both integer
+and floating point matrixes.
----------------
lebedev.ri wrote:
> Column-major-ness seems unusual to me.
> Perhaps motivation can be stated either in the langref, or at least in the review?
The main motivation was that column-major layout seems to be the default for at least a few popular matrix related libraries (proprietary and open source, like Eigen for example: https://eigen.tuxfamily.org/dox/group__TopicStorageOrders.html) we are working on supporting.


================
Comment at: llvm/include/llvm/IR/Intrinsics.td:1235
 
+//===----- Matrix intrinsics ---------------------------------------------===//
+
----------------
lebedev.ri wrote:
> You may want to use `ImmArg` to actually enforce the constant-ness of dimensions.
Nice, I was not aware of that, thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70456/new/

https://reviews.llvm.org/D70456