[PATCH] D70456: [Matrix] Add first set of matrix intrinsics and initial lowering pass.

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added inline comments.


================
Comment at: llvm/docs/LangRef.rst:14417
+embedded in a flat vector and the intrinsics take the dimensions as arguments.
+Currently column-major layout is assumed. The intrinsics support both integer
+and floating point matrixes.
----------------
Column-major-ness seems unusual to me.
Perhaps motivation can be stated either in the langref, or at least in the review?


================
Comment at: llvm/include/llvm/IR/Intrinsics.td:1235
 
+//===----- Matrix intrinsics ---------------------------------------------===//
+
----------------
You may want to use `ImmArg` to actually enforce the constant-ness of dimensions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70456/new/

https://reviews.llvm.org/D70456