[PATCH] D69824: Extends the tblgen macro to allow mlir-tblgen to be installed

Eric Schweitz via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 19 13:38:26 PST 2019


schweitz added a comment.

In D69824#1752102 <https://reviews.llvm.org/D69824#1752102>, @mehdi_amini wrote:

> > In general we don't install tablegen tools because they are tightly tied to the library-based extensibility. For LLVM we do because we support building LLVM targets against installed copies of LLVM. I'm not familiar enough with MLIR, what is the use case for an installed mlir-tblgen tool?
>
> I think the use case for mlir-tblgen is very similar to the external backend case of LLVM. Someone who would develop an out-of-tree dialect for MLIR and would like to build/link against a prebuilt MLIR would need to use the mlir-tblgen that comes with the installed MLIR (or build it themselves)


+1

Exactly. We're using mlir-tblgen as a tool to extend MLIR with our dialect. This change is to allow out-of-tree builds to use mlir-tblgen to generate all the dialect extensions, etc.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69824/new/

https://reviews.llvm.org/D69824





More information about the llvm-commits mailing list