[PATCH] D69824: Extends the tblgen macro to allow mlir-tblgen to be installed

Chris Bieneman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 19 12:52:36 PST 2019


beanz accepted this revision.
beanz added a comment.
This revision is now accepted and ready to land.

Given that, this change LGTM. Using an extra argument would be nice, but this is a macro, not a function, and IIRC CMake argument parsing in macros doesn't really work, so that would be a big change.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69824/new/

https://reviews.llvm.org/D69824





More information about the llvm-commits mailing list