[PATCH] D70447: [Support] ThreadPoolExecutor fixes for Windows/MinGW

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 19 12:43:24 PST 2019


mstorsjo added a comment.

FWIW, this seems to touch on areas also (partially, incompletely) discussed earlier in D53968 <https://reviews.llvm.org/D53968>. (In that one, the issues seemed to be specific to builds with LLVM_LINK_LLVM_DYLIB enabled.)

Also regarding deadlocks on exit in MinGW, for cases with libstdc++ with winpthreads, there are some known such deadlocks that were caused by signaling a condvar without holding the corresponding mutex (see https://sourceforge.net/p/mingw-w64/bugs/774/ for a report on the matter); if I recall correctly this particular deadlock should now be fixed with the latest version of winpthreads, but there might still be other deadlocks lingering.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70447/new/

https://reviews.llvm.org/D70447





More information about the llvm-commits mailing list