[PATCH] D70447: [Support] ThreadPoolExecutor fixes for Windows/MinGW

[Andrew Ng via Phabricator via llvm-commits]

andrewng added a comment.

This patch basically reduces the amount of dependence that ThreadPoolExecutor has on what is effectively undefined behaviour. The changes have been based on issues that have been observed when running LLD on Windows built with the MSVC (2015 & 2017) static run-times and MinGW LLD on Windows.

The patch has been tested on Ubuntu 18.04.3 LTS. I have checked that there is little to no impact on LLD lit testing performance, as the lit testing disables the "fast" exit mode of LLD. In fact, this patch appears to give a slight performance improvement with higher core counts.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70447/new/

https://reviews.llvm.org/D70447