[PATCH] D70451: [FPEnv] IRBuilder should not put strictfp on function definitions automatically

[Kevin P. Neal via Phabricator via llvm-commits]

kpn added a comment.

In D70451#1752027 <https://reviews.llvm.org/D70451#1752027>, @rjmccall wrote:

> This seems like a much more reasonable approach in general.  Frontend authors who intend to use constrained FP need to be making broader changes to how they emit IR in order to satisfy the requirements of the intrinsics.
>
> Have we been able to extract a test case which causes the insertion into an unparented basic block?  If that's happening in Clang IRGen, I consider that a bug.  I can't speak for LLVM passes, though; they do silly things for obscure reasons.


The only one I know of is in this bug report: https://bugs.llvm.org/show_bug.cgi?id=44048

That's the bug that triggered the revert of D62731 <https://reviews.llvm.org/D62731>. I haven't spent enough time in clang to know how to turn this into a real test case for the unparented block issue.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70451/new/

https://reviews.llvm.org/D70451