[PATCH] D70451: [FPEnv] IRBuilder should not put strictfp on function definitions automatically

John McCall via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 19 10:24:43 PST 2019


rjmccall added a comment.

This seems like a much more reasonable approach in general.  Frontend authors who intend to use constrained FP need to be making broader changes to how they emit IR in order to satisfy the requirements of the intrinsics.

Have we been able to extract a test case which causes the insertion into an unparented basic block?  If that's happening in Clang IRGen, I consider that a bug.  I can't speak for LLVM passes, though; they do silly things for obscure reasons.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70451/new/

https://reviews.llvm.org/D70451





More information about the llvm-commits mailing list