[PATCH] D69776: [APFloat] Fix FP remainder operation

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 19 07:26:45 PST 2019


arsenm added inline comments.


================
Comment at: llvm/unittests/ADT/APFloatTest.cpp:3379
+    APFloat expected(APFloat::IEEEdouble(), "-0.5");
+    EXPECT_EQ(f1.remainder(f2), APFloat::opOK);
+    EXPECT_TRUE(f1.bitwiseIsEqual(expected));
----------------
These should be swapped due to a gtestism (same for the rest, it should be expected, actual)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69776/new/

https://reviews.llvm.org/D69776





More information about the llvm-commits mailing list