[PATCH] D69776: [APFloat] Fix FP remainder operation

Hal Finkel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 19 07:20:03 PST 2019


hfinkel added a comment.

Thanks for posting patches to fix problems with the APFloat implementation. FWIW, this code is hard to review, from my perspective, because it lacks comments (both your new code and the code it is replacing). As you clearly have gone through this and understand what it's doing, could you add a bunch of comments explaining what's going on? I think that would be very helpful for everyone else.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69776/new/

https://reviews.llvm.org/D69776





More information about the llvm-commits mailing list