[PATCH] D70405: [AMDGPU] Fix emitIfBreak CF lowering: use a temp register to make register coalescer life easier.

Valery Pykhtin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 19 06:55:03 PST 2019


vpykhtin marked 2 inline comments as done.
vpykhtin added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/loop_break.ll:45
+; GCN:      s_or_b64          [[ACCUM_MASK]], [[AND_MASK]], [[ACCUM_MASK]]
+; GCN:      s_andn2_b64       exec, exec, [[ACCUM_MASK]]
 ; GCN-NEXT: s_cbranch_execnz  [[LOOP_ENTRY]]
----------------
rampitec wrote:
> Probably use of GCN-NEXT here and s_or_b64 above will constitute for the proper testcase.
Did you mean other places too? It looks like a big change though.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70405/new/

https://reviews.llvm.org/D70405





More information about the llvm-commits mailing list