[PATCH] D70292: Make it possible to redirect not only errs() but also outs()

[Rui Ueyama via llvm-commits]

Apologies. I fixed the build issue
in b11386f9be9b2dc7276a758d64f66833da10bdea.

On Mon, Nov 18, 2019 at 9:26 PM James Clarke via Phabricator <
reviews at reviews.llvm.org> wrote:

> jrtc27 added a comment.
>
> This broke `-DBUILD_SHARED_LIBS=ON` for me; `lld::errs()` lives in Common,
> but Core has also been modified to use it, and Common depends on Core, not
> vice versa:
>
>   ld.lld: error: undefined symbol: lld::errs()
>   >>> referenced by Resolver.cpp:226 (lld/lib/Core/Resolver.cpp:226)
>   >>>
>  tools/lld/lib/Core/CMakeFiles/lldCore.dir/Resolver.cpp.o:(lld::Resolver::resolveUndefines())
>
>   ld.lld: error: undefined symbol: lld::errs()
>   >>> referenced by Resolver.cpp:255 (lld/lib/Core/Resolver.cpp:255)
>   >>>
>  tools/lld/lib/Core/CMakeFiles/lldCore.dir/Resolver.cpp.o:(lld::Resolver::resolveUndefines())
>
>   ld.lld: error: undefined symbol: lld::errs()
>   >>> referenced by Resolver.cpp:256 (lld/lib/Core/Resolver.cpp:256)
>   >>>
>  tools/lld/lib/Core/CMakeFiles/lldCore.dir/Resolver.cpp.o:(lld::Resolver::resolveUndefines())
>
>   ld.lld: error: undefined symbol: lld::errs()
>   >>> referenced by Resolver.cpp:269 (lld/lib/Core/Resolver.cpp:269)
>   >>>
>  tools/lld/lib/Core/CMakeFiles/lldCore.dir/Resolver.cpp.o:(lld::Resolver::resolveUndefines())
>
>   ld.lld: error: undefined symbol: lld::errs()
>   >>> referenced by Resolver.cpp:270 (lld/lib/Core/Resolver.cpp:270)
>   >>>
>  tools/lld/lib/Core/CMakeFiles/lldCore.dir/Resolver.cpp.o:(lld::Resolver::resolveUndefines())
>
>   ld.lld: error: undefined symbol: lld::errs()
>   >>> referenced by Resolver.cpp:282 (lld/lib/Core/Resolver.cpp:282)
>   >>>
>  tools/lld/lib/Core/CMakeFiles/lldCore.dir/Resolver.cpp.o:(lld::Resolver::resolveUndefines())
>
>   ld.lld: error: undefined symbol: lld::errs()
>   >>> referenced by Resolver.cpp:283 (lld/lib/Core/Resolver.cpp:283)
>   >>>
>  tools/lld/lib/Core/CMakeFiles/lldCore.dir/Resolver.cpp.o:(lld::Resolver::resolveUndefines())
>
>   ld.lld: error: undefined symbol: lld::errs()
>   >>> referenced by Resolver.cpp:427 (lld/lib/Core/Resolver.cpp:427)
>   >>>
>  tools/lld/lib/Core/CMakeFiles/lldCore.dir/Resolver.cpp.o:(lld::Resolver::checkUndefines())
>
>   ld.lld: error: undefined symbol: lld::errs()
>   >>> referenced by Resolver.cpp:434 (lld/lib/Core/Resolver.cpp:434)
>   >>>
>  tools/lld/lib/Core/CMakeFiles/lldCore.dir/Resolver.cpp.o:(lld::Resolver::checkUndefines())
>
>   ld.lld: error: undefined symbol: lld::errs()
>   >>> referenced by SymbolTable.cpp:160 (lld/lib/Core/SymbolTable.cpp:160)
>   >>>
>  tools/lld/lib/Core/CMakeFiles/lldCore.dir/SymbolTable.cpp.o:(lld::SymbolTable::addByName(lld::Atom
> const&))
>
>   ld.lld: error: undefined symbol: lld::errs()
>   >>> referenced by SymbolTable.cpp:166 (lld/lib/Core/SymbolTable.cpp:166)
>   >>>
>  tools/lld/lib/Core/CMakeFiles/lldCore.dir/SymbolTable.cpp.o:(lld::SymbolTable::addByName(lld::Atom
> const&))
>
>   ld.lld: error: undefined symbol: lld::errs()
>   >>> referenced by SymbolTable.cpp:190 (lld/lib/Core/SymbolTable.cpp:190)
>   >>>
>  tools/lld/lib/Core/CMakeFiles/lldCore.dir/SymbolTable.cpp.o:(lld::SymbolTable::addByName(lld::Atom
> const&))
>   collect2: error: ld returned 1 exit status
>
>
> Repository:
>   rG LLVM Github Monorepo
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D70292/new/
>
> https://reviews.llvm.org/D70292
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191119/98c013ae/attachment.html>