<div dir="ltr">Apologies. I fixed the build issue in b11386f9be9b2dc7276a758d64f66833da10bdea.</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Nov 18, 2019 at 9:26 PM James Clarke via Phabricator <<a href="mailto:reviews@reviews.llvm.org">reviews@reviews.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">jrtc27 added a comment.<br>
<br>
This broke `-DBUILD_SHARED_LIBS=ON` for me; `lld::errs()` lives in Common, but Core has also been modified to use it, and Common depends on Core, not vice versa:<br>
<br>
  ld.lld: error: undefined symbol: lld::errs()<br>
  >>> referenced by Resolver.cpp:226 (lld/lib/Core/Resolver.cpp:226)<br>
  >>>               tools/lld/lib/Core/CMakeFiles/lldCore.dir/Resolver.cpp.o:(lld::Resolver::resolveUndefines())<br>
<br>
  ld.lld: error: undefined symbol: lld::errs()<br>
  >>> referenced by Resolver.cpp:255 (lld/lib/Core/Resolver.cpp:255)<br>
  >>>               tools/lld/lib/Core/CMakeFiles/lldCore.dir/Resolver.cpp.o:(lld::Resolver::resolveUndefines())<br>
<br>
  ld.lld: error: undefined symbol: lld::errs()<br>
  >>> referenced by Resolver.cpp:256 (lld/lib/Core/Resolver.cpp:256)<br>
  >>>               tools/lld/lib/Core/CMakeFiles/lldCore.dir/Resolver.cpp.o:(lld::Resolver::resolveUndefines())<br>
<br>
  ld.lld: error: undefined symbol: lld::errs()<br>
  >>> referenced by Resolver.cpp:269 (lld/lib/Core/Resolver.cpp:269)<br>
  >>>               tools/lld/lib/Core/CMakeFiles/lldCore.dir/Resolver.cpp.o:(lld::Resolver::resolveUndefines())<br>
<br>
  ld.lld: error: undefined symbol: lld::errs()<br>
  >>> referenced by Resolver.cpp:270 (lld/lib/Core/Resolver.cpp:270)<br>
  >>>               tools/lld/lib/Core/CMakeFiles/lldCore.dir/Resolver.cpp.o:(lld::Resolver::resolveUndefines())<br>
<br>
  ld.lld: error: undefined symbol: lld::errs()<br>
  >>> referenced by Resolver.cpp:282 (lld/lib/Core/Resolver.cpp:282)<br>
  >>>               tools/lld/lib/Core/CMakeFiles/lldCore.dir/Resolver.cpp.o:(lld::Resolver::resolveUndefines())<br>
<br>
  ld.lld: error: undefined symbol: lld::errs()<br>
  >>> referenced by Resolver.cpp:283 (lld/lib/Core/Resolver.cpp:283)<br>
  >>>               tools/lld/lib/Core/CMakeFiles/lldCore.dir/Resolver.cpp.o:(lld::Resolver::resolveUndefines())<br>
<br>
  ld.lld: error: undefined symbol: lld::errs()<br>
  >>> referenced by Resolver.cpp:427 (lld/lib/Core/Resolver.cpp:427)<br>
  >>>               tools/lld/lib/Core/CMakeFiles/lldCore.dir/Resolver.cpp.o:(lld::Resolver::checkUndefines())<br>
<br>
  ld.lld: error: undefined symbol: lld::errs()<br>
  >>> referenced by Resolver.cpp:434 (lld/lib/Core/Resolver.cpp:434)<br>
  >>>               tools/lld/lib/Core/CMakeFiles/lldCore.dir/Resolver.cpp.o:(lld::Resolver::checkUndefines())<br>
<br>
  ld.lld: error: undefined symbol: lld::errs()<br>
  >>> referenced by SymbolTable.cpp:160 (lld/lib/Core/SymbolTable.cpp:160)<br>
  >>>               tools/lld/lib/Core/CMakeFiles/lldCore.dir/SymbolTable.cpp.o:(lld::SymbolTable::addByName(lld::Atom const&))<br>
<br>
  ld.lld: error: undefined symbol: lld::errs()<br>
  >>> referenced by SymbolTable.cpp:166 (lld/lib/Core/SymbolTable.cpp:166)<br>
  >>>               tools/lld/lib/Core/CMakeFiles/lldCore.dir/SymbolTable.cpp.o:(lld::SymbolTable::addByName(lld::Atom const&))<br>
<br>
  ld.lld: error: undefined symbol: lld::errs()<br>
  >>> referenced by SymbolTable.cpp:190 (lld/lib/Core/SymbolTable.cpp:190)<br>
  >>>               tools/lld/lib/Core/CMakeFiles/lldCore.dir/SymbolTable.cpp.o:(lld::SymbolTable::addByName(lld::Atom const&))<br>
  collect2: error: ld returned 1 exit status<br>
<br>
<br>
Repository:<br>
  rG LLVM Github Monorepo<br>
<br>
CHANGES SINCE LAST ACTION<br>
  <a href="https://reviews.llvm.org/D70292/new/" rel="noreferrer" target="_blank">https://reviews.llvm.org/D70292/new/</a><br>
<br>
<a href="https://reviews.llvm.org/D70292" rel="noreferrer" target="_blank">https://reviews.llvm.org/D70292</a><br>
<br>
<br>
<br>
</blockquote></div>