[PATCH] D70405: [AMDGPU] Fix emitIfBreak CF lowering: use a temp register to make register coalescer life easier.

Valery Pykhtin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 18 09:38:27 PST 2019


vpykhtin created this revision.
vpykhtin added reviewers: rampitec, alex-t, nhaehnle.
Herald added subscribers: llvm-commits, hiraditya, t-tye, tpr, dstuttard, yaxunl, wdng, jvesely, kzhuravl, arsenm.
Herald added a project: LLVM.

The change allows the register coalescer to avoid unnecessary register interference and save a move on ifBreak control flow sequence.

I didn't make a test for this as its a bit hard and existing tests covers this functionality - I can see some movs gone.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D70405

Files:
  llvm/lib/Target/AMDGPU/SILowerControlFlow.cpp
  llvm/test/CodeGen/AMDGPU/i1-copy-from-loop.ll
  llvm/test/CodeGen/AMDGPU/loop_break.ll
  llvm/test/CodeGen/AMDGPU/multilevel-break.ll
  llvm/test/CodeGen/AMDGPU/si-annotate-cf.ll
  llvm/test/CodeGen/AMDGPU/valu-i1.ll
  llvm/test/CodeGen/AMDGPU/wave32.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D70405.229871.patch
Type: text/x-patch
Size: 8395 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191118/5ad8bd62/attachment.bin>


More information about the llvm-commits mailing list