[PATCH] D70126: [PowerPC] Refactor FinishCall

Sean Fertile via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 18 09:11:34 PST 2019


sfertile updated this revision to Diff 229862.
sfertile marked 9 inline comments as done.
sfertile added a comment.

- Various spelling and punctuation fixes.
- made 'buildCallOperands' static
- Added a comment in the 'useFunctionDescriptors' querry.
- renamed 'buildIndirectCall' and 'buildDescriptorIndirectCall' by changing 'build' to 'prepare' --> The helpers build the DAGs, setting up the call, but don't insert the call instruction itself so 'prepare' is a better description then 'build'.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70126/new/

https://reviews.llvm.org/D70126

Files:
  llvm/lib/Target/PowerPC/PPCISelLowering.cpp
  llvm/lib/Target/PowerPC/PPCSubtarget.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D70126.229862.patch
Type: text/x-patch
Size: 31738 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191118/fe9eaadc/attachment.bin>


More information about the llvm-commits mailing list