[PATCH] D70126: [PowerPC] Refactor FinishCall

Mon Nov 18 06:48:55 PST 2019

cebowleratibm added a comment.

The new logic is much clearer, though it's hard to discern that the semantics remain correct because so much logic was redistributed.  If a series of smaller commits were possible it would be easier to review.

================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:5222
+
+void buildCallOperands(SmallVectorImpl<SDValue> &Ops, CallingConv::ID CallConv,
+                       const SDLoc &dl, bool isTailCall, bool isVarArg,
----------------
Did you intend buildCallOperands to be static?

================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:5290
-      // Restore the caller TOC from the save area into R2.
-      // See PrepareCall() for more information about calls through function
-      // pointers in the 64-bit SVR4 ABI.
----------------
You've removed PrepareCall and should update the comment.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70126/new/

https://reviews.llvm.org/D70126