[PATCH] D70156: [APInt] Fix tests that had wrong assumption about sdivs with negative quotient.

Sanjoy Das via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Nov 17 10:51:17 PST 2019


sanjoy requested changes to this revision.
sanjoy added a comment.
This revision now requires changes to proceed.

Can you please describe what was wrong about the unit tests in the commit message?



================
Comment at: llvm/unittests/ADT/APIntTest.cpp:2596
+                   B.isNegative()) { // if the math quotient is negative.
+          EXPECT_TRUE(Quo == QuoTowardZero - 1);
+        } else {
----------------
Can this be `EXPECT_EQ`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70156/new/

https://reviews.llvm.org/D70156





More information about the llvm-commits mailing list