[PATCH] D70261: [strictfp] Add token support for FP constraints

[Simon Moll via Phabricator via llvm-commits]

simoll added a comment.

In D70261#1747498 <https://reviews.llvm.org/D70261#1747498>, @uweigand wrote:

> I like the notion of having those values expressed directly as LLVM IR tokens


+1
I also like the (optional) operand bundles (see llvm-dev reply <https://lists.llvm.org/pipermail/llvm-dev/2019-November/136815.html>).

Quoting: https://llvm.org/docs/LangRef.html#token-type

> "The token type is used when a value is associated with an instruction but all uses of the value **must not attempt to introspect or obscure it**. As such, it is not appropriate to have a phi or select of type token."

That seems to be a pretty accurate description of how the fpround/fpexcept params are supposed to be handled (they must not change the operation/implementation of the constrained fp op).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70261/new/

https://reviews.llvm.org/D70261