[PATCH] D70261: [strictfp] Add token support for FP constraints

[Ulrich Weigand via Phabricator via llvm-commits]

uweigand added a comment.

I like the notion of having those values expressed directly as LLVM IR tokens, but I'm not really sure the LLVM "token" type is the correct way to represent those.

The way I understood the token type as described in the IR docs, it seems to be intended to hold opaque numerical values generated **at run time** by some system library; in the only real current use case, this would be the Windows exception dispatch library.

Using it, like here, to encode LLVM internal compile-time enumeration values seems to be a bit of an overloading of that concept.  I think this may probably need to be discussed more with the wider community, maybe on llvm-dev?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70261/new/

https://reviews.llvm.org/D70261