[PATCH] D67283: [GCOV] Skip artificial functions from being emitted

[Adrian Prantl via Phabricator via llvm-commits]

aprantl accepted this revision.
aprantl added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/GCOVProfiling.cpp:741-742
 
           // Artificial lines such as calls to the global constructors.
           if (Loc.getLine() == 0 || Loc.isImplicitCode())
             continue;
----------------
rnk wrote:
> @aprantl I suspect this preexisting code was the model for the check above. Maybe it should be standardized to isArtificial to. This is not blocking to this patch, of course.
You can easily have line 0 locations inside a non-artificial function, but the comment doesn't make it sound like that's what they were after here...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67283/new/

https://reviews.llvm.org/D67283