[PATCH] D67283: [GCOV] Skip artificial functions from being emitted
    Reid Kleckner via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Thu Nov 14 10:52:33 PST 2019
    
    
  
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
Sorry for the delay, things happened, I got distracted.
================
Comment at: llvm/lib/Transforms/Instrumentation/GCOVProfiling.cpp:741-742
 
           // Artificial lines such as calls to the global constructors.
           if (Loc.getLine() == 0 || Loc.isImplicitCode())
             continue;
----------------
@aprantl I suspect this preexisting code was the model for the check above. Maybe it should be standardized to isArtificial to. This is not blocking to this patch, of course.
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67283/new/
https://reviews.llvm.org/D67283
    
    
More information about the llvm-commits
mailing list