[PATCH] D11833: s/NDEBUG/LLVM_NDEBUG/ in most places

[Roger Jarrett via Phabricator via llvm-commits]

rogerjarrett added a comment.

Issue appears to still  be present 
For example: In llvm/include/llvm/Transforms/Scalar/LoopPassManager.h

https://llvm.org/doxygen/LoopPassManager_8h_source.html

line 207
... 
#ifndef NDEBUG

  for (Loop *NewL : NewChildLoops)
    assert(NewL->getParentLoop() == CurrentL && "All of the new loops must "
                                                "be immediate children of "
                                                "the current loop!");

#endif
...

Running the command:  find . -iname '*.h' | xargs grep '^#' -- | grep -vE '^.*:.*(LLVM_|cplusplus|endif|else|include|define )' | grep NDEBUG | wc -l

returns 
150 instances of NDEBUG  in .h files the 9.0.0  code base.

Best,
--Roger


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D11833/new/

https://reviews.llvm.org/D11833