[PATCH] D11833: s/NDEBUG/LLVM_NDEBUG/ in most places

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 13 13:00:14 PST 2019


mehdi_amini added a comment.

In D11833#1742834 <https://reviews.llvm.org/D11833#1742834>, @rogerjarrett wrote:

> +1 on Goal  In particular the use of NDEBUG in external interface header files causes significant pain when using the header files in a build environment that uses NDEBUG
>
> What steps are needed to move this change forward?


Is this still a problem? Aren't all the header checks guarded by LLVM_ENABLE_ABI_BREAKING_CHECKS now?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D11833/new/

https://reviews.llvm.org/D11833





More information about the llvm-commits mailing list