[PATCH] D70223: [DAGCombine] Split vector load-update-store into single element stores

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

This is missing test coverage.



================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:6799-6801
+  if (TLI.isCheapToSplitStore(N, UpdatedElementsIdx.size(), DAG) &&
+      TLI.getOperationAction(ISD::STORE, EleVT) == TargetLowering::Legal &&
+      TLI.allowsMemoryAccess(*DAG.getContext(), DAG.getDataLayout(), EleVT)) {
----------------
It would be best to do as much of this checking as early as possible, before calling `getVectorUpdates()`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70223/new/

https://reviews.llvm.org/D70223