[PATCH] D69891: [VP,Integer,#1] Vector-predicated integer intrinsics

[Stefan Stipanovic via Phabricator via llvm-commits]

sstefan1 added inline comments.


================
Comment at: llvm/include/llvm/IR/Intrinsics.td:1172
+
+}
+
----------------
simoll wrote:
> jdoerfert wrote:
> > simoll wrote:
> > > jdoerfert wrote:
> > > > I guess you can add readnone as an attribute, also nosync and nofree please.
> > > The intrinsics are `readnone` already. `nosync` seems sensible.
> > I asked @sstefan1 to add nosync and nofree to the td file and other places needed to use them. That should make your changes more concise.
> > 
> > ---
> > 
> > I would have argued we could even do the `#inline` trick here, or maybe some .td magic, to avoid this replication, but I will not force anything.
> > I would have argued we could even do the `#inline` trick here, or maybe some .td magic, to avoid this replication, but I will not force anything.
> 
> I agree but refactoring `Intrinsics.td` is out of scope for this patch.
I kind of started some of this in D65377 and the approach will try and propose is an opt-out list.

If I understood correctly I should try to do that part first (and propose). @jdoerfert correct me if I'm wrong.

Hopefully I'll start this today.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69891/new/

https://reviews.llvm.org/D69891