[PATCH] D69146: [install-name-tool] Add first bits for install-name-tool

[Seiya Nuta via Phabricator via llvm-commits]

seiya added a comment.

It's too late to review but in case you haven't started digging into the root cause. I believe this is why buildbots fail.



================
Comment at: llvm/tools/llvm-objcopy/CopyConfig.cpp:838
+  Config.InputFilename = Positional[0];
+  Config.OutputFilename = Positional[0];
+
----------------
Missing `InputFormat` and `OutputFormat` initialization?

```
  Config.InputFormat = FileFormat::Unspecified;
  Config.OutputFormat = FileFormat::Unspecified;
```

It's error-prone so setting it as default member values in `struct CopyConfig` would be better:

```
struct CopyConfig {
   ...
   FileFormat InputFormat = FileFormat::Unspecified;
   FileFormat OutputFormat = FileFormat::Unspecified;
```



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69146/new/

https://reviews.llvm.org/D69146