[PATCH] D29014: [SelDag] Implement FREEZE node

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/include/llvm/Support/TargetOpcodes.def:59
 
+/// IMPLICIT_DEF - This is the MachineInstr-level equivalent of freeze.
+HANDLE_TARGET_OPCODE(FREEZE)
----------------
Comment says IMPLICIT_DEF


================
Comment at: llvm/lib/CodeGen/SelectionDAG/FastISel.cpp:1571
 
+bool FastISel::selectFreeze(const User *I) {
+  // Lower Freeze to reg-reg copy.
----------------
Why doesn't this TargetOpcode::Freeze?


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:3106
   SDValue Op = getValue(I.getOperand(0));
+  if (I.getOperand(0)->getType()->isAggregateType()) {
+    assert(Opcode == ISD::FREEZE && "Can only get here for freeze nodes");
----------------
Separate this into just visitFreeze.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D29014/new/

https://reviews.llvm.org/D29014