[PATCH] D70085: [AMDGPU] NFC target dependent requiresUniformRegister refactored out

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 11 12:03:14 PST 2019


rampitec added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/TargetLowering.h:709
+  /// specific value. Base class implementation returns true
+  /// if the Divergent Analysis exists and reports value as divergent.
+  virtual bool isDivergent(const LegacyDivergenceAnalysis *DA,
----------------
Typo: Divergent Analysis -> Divergence Analysis


================
Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.h:408
+  bool requiresUniformRegister(MachineFunction &MF, 
+                                       const Value *V) const;
   Align getPrefLoopAlignment(MachineLoop *ML) const override;
----------------
Formatting is off.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70085/new/

https://reviews.llvm.org/D70085





More information about the llvm-commits mailing list