[PATCH] D69753: [InstCombine] Canonicalize ssub.with.overflow to ssub.sat

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 11 06:14:47 PST 2019


spatel added a comment.

In D69753#1740262 <https://reviews.llvm.org/D69753#1740262>, @dmgreen wrote:

> Update/rebase. Let me know if there's a better way to structure this that you can think of.


Ah, I didn't catch that asymmetry between add (commutative) and sub (not commutative). I don't have any good suggestions to make it shorter. Even if there is, it's better to commit this as-is to make sure the logic is correct in this form vs. any non-obvious reduced form.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69753/new/

https://reviews.llvm.org/D69753





More information about the llvm-commits mailing list