[PATCH] D69899: [RISCV] Improve assembler missing feature warnings

Simon Cook via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 7 03:42:42 PST 2019


simoncook added a comment.

In D69899#1736771 <https://reviews.llvm.org/D69899#1736771>, @edward-jones wrote:

> This looks good to me, the only thing that I'm not sure about is the phrasing of the warnings:
>
> "error: instruction requires the following: RV32I Base Instruction Set"
>
> For a naive user (like me) I think the 'I' could make them focus on the extension as the problem, not the fact that's it's RV32 vs RV64.


I've used the names of the extensions as per the spec (and the SubtargetFeature) in order to map it back more easily to the spec, a user can search for one of these strings in the spec and find out what it is they are missing.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69899/new/

https://reviews.llvm.org/D69899





More information about the llvm-commits mailing list