[PATCH] D69899: [RISCV] Improve assembler missing feature warnings
    Edward Jones via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Thu Nov  7 03:24:16 PST 2019
    
    
  
edward-jones added a comment.
This looks good to me, the only thing that I'm not sure about is the phrasing of the warnings:
"error: instruction requires the following: RV32I Base Instruction Set"
For a naive user (like me) I think the 'I' could make them focus on the extension as the problem, not the fact that's it's RV32 vs RV64.
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69899/new/
https://reviews.llvm.org/D69899
    
    
More information about the llvm-commits
mailing list