[PATCH] D69146: [install-name-tool] Add first bits for install-name-tool

Wed Nov 6 16:34:12 PST 2019

leonardchan added a comment.

Not sure if this was reported yet, but this seems to cause a test to fail on our mac bots (https://ci.chromium.org/p/fuchsia/builders/ci/clang-mac-x64/b8897508854751497616):

  FAIL: LLVM :: tools/llvm-objcopy/MachO/install-name-tool-add-rpath.test (33474 of 34284)
  ******************** TEST 'LLVM :: tools/llvm-objcopy/MachO/install-name-tool-add-rpath.test' FAILED ********************
  Script:
  --
  : 'RUN: at line 3';   /b/s/w/ir/k/recipe_cleanup/clangDzYrtf/llvm_build_dir/bin/yaml2obj /b/s/w/ir/k/llvm-project/llvm/test/tools/llvm-objcopy/MachO/Inputs/i386.yaml > /b/s/w/ir/k/recipe_cleanup/clangDzYrtf/llvm_build_dir/test/tools/llvm-objcopy/MachO/Output/install-name-tool-add-rpath.test.tmp.i386
  : 'RUN: at line 4';   llvm-install-name-tool -add_rpath @executable_path/. /b/s/w/ir/k/recipe_cleanup/clangDzYrtf/llvm_build_dir/test/tools/llvm-objcopy/MachO/Output/install-name-tool-add-rpath.test.tmp.i386
  : 'RUN: at line 5';   /b/s/w/ir/k/recipe_cleanup/clangDzYrtf/llvm_build_dir/bin/llvm-objdump -p /b/s/w/ir/k/recipe_cleanup/clangDzYrtf/llvm_build_dir/test/tools/llvm-objcopy/MachO/Output/install-name-tool-add-rpath.test.tmp.i386 | /b/s/w/ir/k/recipe_cleanup/clangDzYrtf/llvm_build_dir/bin/FileCheck --check-prefix=NEW-RPATH /b/s/w/ir/k/llvm-project/llvm/test/tools/llvm-objcopy/MachO/install-name-tool-add-rpath.test
  : 'RUN: at line 7';   /b/s/w/ir/k/recipe_cleanup/clangDzYrtf/llvm_build_dir/bin/yaml2obj /b/s/w/ir/k/llvm-project/llvm/test/tools/llvm-objcopy/MachO/Inputs/x86_64.yaml > /b/s/w/ir/k/recipe_cleanup/clangDzYrtf/llvm_build_dir/test/tools/llvm-objcopy/MachO/Output/install-name-tool-add-rpath.test.tmp.x86_64
  : 'RUN: at line 8';   llvm-install-name-tool -add_rpath @executable_path/. /b/s/w/ir/k/recipe_cleanup/clangDzYrtf/llvm_build_dir/test/tools/llvm-objcopy/MachO/Output/install-name-tool-add-rpath.test.tmp.x86_64
  : 'RUN: at line 9';   /b/s/w/ir/k/recipe_cleanup/clangDzYrtf/llvm_build_dir/bin/llvm-objdump -p /b/s/w/ir/k/recipe_cleanup/clangDzYrtf/llvm_build_dir/test/tools/llvm-objcopy/MachO/Output/install-name-tool-add-rpath.test.tmp.x86_64 | /b/s/w/ir/k/recipe_cleanup/clangDzYrtf/llvm_build_dir/bin/FileCheck --check-prefix=NEW-RPATH /b/s/w/ir/k/llvm-project/llvm/test/tools/llvm-objcopy/MachO/install-name-tool-add-rpath.test
  : 'RUN: at line 15';   not llvm-install-name-tool -add_rpath @executable_path/. /b/s/w/ir/k/recipe_cleanup/clangDzYrtf/llvm_build_dir/test/tools/llvm-objcopy/MachO/Output/install-name-tool-add-rpath.test.tmp.i386 2>&1  | /b/s/w/ir/k/recipe_cleanup/clangDzYrtf/llvm_build_dir/bin/FileCheck --check-prefix=DUPLICATE-RPATH /b/s/w/ir/k/llvm-project/llvm/test/tools/llvm-objcopy/MachO/install-name-tool-add-rpath.test
  : 'RUN: at line 20';   not llvm-install-name-tool -add_rpath @executable_path/. 2>&1  | /b/s/w/ir/k/recipe_cleanup/clangDzYrtf/llvm_build_dir/bin/FileCheck --check-prefix=NO-INPUT /b/s/w/ir/k/llvm-project/llvm/test/tools/llvm-objcopy/MachO/install-name-tool-add-rpath.test
  --
  Exit Code: 134

  Command Output (stderr):
  --
  unsupported output format
  UNREACHABLE executed at /b/s/w/ir/k/llvm-project/llvm/tools/llvm-objcopy/llvm-objcopy.cpp:160!
  /b/s/w/ir/k/recipe_cleanup/clangDzYrtf/llvm_build_dir/test/tools/llvm-objcopy/MachO/Output/install-name-tool-add-rpath.test.script: line 8: 60369 Abort trap: 6           llvm-install-name-tool -add_rpath @executable_path/. /b/s/w/ir/k/recipe_cleanup/clangDzYrtf/llvm_build_dir/test/tools/llvm-objcopy/MachO/Output/install-name-tool-add-rpath.test.tmp.i386

  --

  ********************
  Testing:  0.. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90.. 

  Testing Time: 146.11s
  ********************
  Failing Tests (1):
      LLVM :: tools/llvm-objcopy/MachO/install-name-tool-add-rpath.test

Could you take a look? Thanks

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69146/new/

https://reviews.llvm.org/D69146