[PATCH] D69146: [install-name-tool] Add first bits for install-name-tool

[Alexander Shaposhnikov via Phabricator via llvm-commits]

alexshap marked an inline comment as done.
alexshap added inline comments.


================
Comment at: llvm/tools/llvm-objcopy/CMakeLists.txt:47
   add_llvm_tool_symlink(objcopy llvm-objcopy)
   add_llvm_tool_symlink(strip llvm-objcopy)
 endif()
----------------
smeenai wrote:
> thakis wrote:
> > do you want to add a symlink install_name_tool down here too if LLVM_INSTALL_BINUTILS_SYMLINKS is set?
> That should be controlled by `LLVM_INSTALL_CCTOOLS_SYMLINKS`.
I think it should be guarded by the variable LLVM_INSTALL_CCTOOLS_SYMLINKS instead (similarly to llvm-lipo)
(since install_name_tool is a part of cctools, not binutils),
but right now  llvm-install-name-tool supports only one flag, so we have to continue using cctools' install_name_tool in the meantime. But yeah, we will need this symbolic link in the future, I'll send a diff (just wanted to get the tool into a better shape first).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69146/new/

https://reviews.llvm.org/D69146