[PATCH] D69709: [yaml2obj][WIP] - Add a way to describe the custom data that is not part of an output section.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/include/llvm/ObjectYAML/ELFYAML.h:226
 
-  static bool nameMatches(StringRef Name) {
-    return Name == ".stack_sizes";
-  }
+  static bool nameMatches(StringRef Name) { return Name == ".stack_sizes"; }
 };
----------------
Looks like unrelated.


================
Comment at: llvm/include/llvm/ObjectYAML/ELFYAML.h:269
+
+  static bool classof(const Section *S) {
+    return S->Kind == SectionKind::Note;
----------------
Looks like unrelated.


================
Comment at: llvm/include/llvm/ObjectYAML/ELFYAML.h:317
 
-  static bool classof(const Section *S) { return S->Kind == SectionKind::GnuHash; }
+  static bool classof(const Section *S) {
+    return S->Kind == SectionKind::GnuHash;
----------------
Looks like unrelated.


================
Comment at: llvm/lib/ObjectYAML/ELFEmitter.cpp:94
+struct PhdrEntry {
+  uint64_t ShOffset;
+  uint64_t ShSize;
----------------
`SegmentFragment` may be a better name. `Phdr` (program header) looks to me properties that describe the program header, but here this structure describes fragments that make up the segment content.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69709/new/

https://reviews.llvm.org/D69709