[PATCH] D69686: [LVI][CVP] Use block value in getPredicateAt()

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 4 06:32:40 PST 2019


lebedev.ri added inline comments.


================
Comment at: llvm/lib/Analysis/LazyValueInfo.cpp:1869-1871
+  ValueLatticeElement Result = V->getType()->isPointerTy()
+    ? getImpl(PImpl, AC, &DL, DT).getValueAt(V, CxtI)
+    : getImpl(PImpl, AC, &DL, DT).getValueInBlock(V, CxtI->getParent(), CxtI);
----------------
Should we be getting both, and combining their knowledge somehow?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69686/new/

https://reviews.llvm.org/D69686





More information about the llvm-commits mailing list