[PATCH] D69686: [LVI][CVP] Use block value in getPredicateAt()

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

Interestingly, we seriously regress in NSW deductions:

  | statistic                                 |     old |     new | delta |  % change |
  | correlated-value-propagation.NumAShrs     |     209 |     438 |   229 | 109.5694% |
  | correlated-value-propagation.NumAddNSW    |    4972 |    4237 |  -735 | -14.7828% |
  | correlated-value-propagation.NumAddNUW    |    7141 |    7157 |    16 |   0.2241% |
  | correlated-value-propagation.NumAddNW     |   12113 |   11394 |  -719 |  -5.9358% |
  | correlated-value-propagation.NumAnd       |     442 |     441 |    -1 |  -0.2262% |
  | correlated-value-propagation.NumCmps      |    1194 |    1183 |   -11 |  -0.9213% |
  | correlated-value-propagation.NumDeadCases |     111 |     115 |     4 |   3.6036% |
  | correlated-value-propagation.NumMulNSW    |     278 |     276 |    -2 |  -0.7194% |
  | correlated-value-propagation.NumMulNUW    |    1326 |    1324 |    -2 |  -0.1508% |
  | correlated-value-propagation.NumMulNW     |    1604 |    1600 |    -4 |  -0.2494% |
  | correlated-value-propagation.NumNSW       |    7160 |    6415 |  -745 | -10.4050% |
  | correlated-value-propagation.NumNUW       |   13306 |   13315 |     9 |   0.0676% |
  | correlated-value-propagation.NumNW        |   20466 |   19730 |  -736 |  -3.5962% |
  | correlated-value-propagation.NumOverflows |       7 |       4 |    -3 | -42.8571% |
  | correlated-value-propagation.NumPhiCommon |     397 |     401 |     4 |   1.0076% |
  | correlated-value-propagation.NumPhis      |   15360 |   15435 |    75 |   0.4883% |
  | correlated-value-propagation.NumSDivs     |     207 |     304 |    97 |  46.8599% |
  | correlated-value-propagation.NumSExt      |    6278 |    7226 |   948 |  15.1004% |
  | correlated-value-propagation.NumSRems     |      28 |      49 |    21 |  75.0000% |
  | correlated-value-propagation.NumShlNSW    |    1171 |    1160 |   -11 |  -0.9394% |
  | correlated-value-propagation.NumShlNUW    |    2793 |    2783 |   -10 |  -0.3580% |
  | correlated-value-propagation.NumShlNW     |    3964 |    3943 |   -21 |  -0.5298% |
  | correlated-value-propagation.NumSubNSW    |     739 |     742 |     3 |   0.4060% |
  | correlated-value-propagation.NumSubNUW    |    2046 |    2051 |     5 |   0.2444% |
  | correlated-value-propagation.NumSubNW     |    2785 |    2793 |     8 |   0.2873% |
  | correlated-value-propagation.NumUDivs     |     353 |     375 |    22 |   6.2323% |
  | instcount.NumAShrInst                     |   13761 |   13588 |  -173 |  -1.2572% |
  | instcount.NumAddInst                      |  277538 |  277585 |    47 |   0.0169% |
  | instcount.NumAllocaInst                   |   28040 |   28043 |     3 |   0.0107% |
  | instcount.NumAndInst                      |   66082 |   66163 |    81 |   0.1226% |
  | instcount.NumBitCastInst                  |  675473 |  675587 |   114 |   0.0169% |
  | instcount.NumBrInst                       |  712987 |  712797 |  -190 |  -0.0266% |
  | instcount.NumCallInst                     |  528453 |  528461 |     8 |   0.0015% |
  | instcount.NumExtractElementInst           |   19418 |   19420 |     2 |   0.0103% |
  | instcount.NumFCmpInst                     |   11039 |   11037 |    -2 |  -0.0181% |
  | instcount.NumFNegInst                     |    1270 |    1272 |     2 |   0.1575% |
  | instcount.NumFSubInst                     |   90911 |   90915 |     4 |   0.0044% |
  | instcount.NumGetElementPtrInst            | 1229297 | 1229518 |   221 |   0.0180% |
  | instcount.NumICmpInst                     |  487467 |  487413 |   -54 |  -0.0111% |
  | instcount.NumInvokeInst                   |   21780 |   21779 |    -1 |  -0.0046% |
  | instcount.NumLShrInst                     |   27409 |   27587 |   178 |   0.6494% |
  | instcount.NumLoadInst                     |  890831 |  890834 |     3 |   0.0003% |
  | instcount.NumMulInst                      |   43841 |   43832 |    -9 |  -0.0205% |
  | instcount.NumOrInst                       |  102648 |  102652 |     4 |   0.0039% |
  | instcount.NumPHIInst                      |  317805 |  317726 |   -79 |  -0.0249% |
  | instcount.NumPtrToIntInst                 |   16114 |   16116 |     2 |   0.0124% |
  | instcount.NumRetInst                      |   88782 |   88777 |    -5 |  -0.0056% |
  | instcount.NumSDivInst                     |    8732 |    8670 |   -62 |  -0.7100% |
  | instcount.NumSExtInst                     |   79306 |   78745 |  -561 |  -0.7074% |
  | instcount.NumSRemInst                     |    1679 |    1678 |    -1 |  -0.0596% |
  | instcount.NumSelectInst                   |   46181 |   46251 |    70 |   0.1516% |
  | instcount.NumShlInst                      |   40640 |   40575 |   -65 |  -0.1599% |
  | instcount.NumShuffleVectorInst            |  100326 |  100317 |    -9 |  -0.0090% |
  | instcount.NumStoreInst                    |  814080 |  814211 |   131 |   0.0161% |
  | instcount.NumSubInst                      |   61973 |   61976 |     3 |   0.0048% |
  | instcount.NumTruncInst                    |   62132 |   62166 |    34 |   0.0547% |
  | instcount.NumUDivInst                     |    2526 |    2535 |     9 |   0.3563% |
  | instcount.NumURemInst                     |    1589 |    1598 |     9 |   0.5664% |
  | instcount.NumUnreachableInst              |   13486 |   13467 |   -19 |  -0.1409% |
  | instcount.NumXorInst                      |   10632 |   10643 |    11 |   0.1035% |
  | instcount.NumZExtInst                     |   68227 |   69001 |   774 |   1.1344% |
  | instcount.TotalBlocks                     |  847787 |  847572 |  -215 |  -0.0254% |
  | instcount.TotalFuncs                      |   88847 |   88843 |    -4 |  -0.0045% |
  | instcount.TotalInsts                      | 7411666 | 7412146 |   480 |   0.0065% |


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69686/new/

https://reviews.llvm.org/D69686