[PATCH] D57504: RFC: Prototype & Roadmap for vector predication in LLVM

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer added a comment.

In D57504#1726715 <https://reviews.llvm.org/D57504#1726715>, @simoll wrote:

> In D57504#1726007 <https://reviews.llvm.org/D57504#1726007>, @SjoerdMeijer wrote:
>
> > Hi Simon, I went through the code for the first time, and this is a first round of proper nitpicks from my side. Please ignore if you want to focus on the bigger picture at this point in the discussion, but these are just some things I noticed. General nitpick is that you should run clang-format as there are quite a few coding style issues: indentation, indentation of arguments, exceeding 80 columns, placement of `*` and `&` in arguments and return values, etc.  And find some more nitpicks inlined.
>
>
> Hi Sjoerd, thanks for you comments! i've fixed the inline nitpicks right away. I'll do a style pass for the actual commits.


Cheers. Just curious, what are your next steps? People can correct me if I'm wrong, but my impression is that with the RFC, this prototype, the discussion at the US LLVM dev conference, there is consensus and people are on-board with the general idea and direction. There are still some discussions on e.g. the (constrained) FP part, but would it now be the time split this for example up in an separate commits, like an INT and FP part (if that makes sense), so that they can be (separately) progressed?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57504/new/

https://reviews.llvm.org/D57504